Re: [Mesa-dev] [PATCH v2 03/25] anv: tweak the %.json rule

2016-05-04 Thread Knut Andre Tidemann
On fredag 22. april 2016 19.55.10 CEST Emil Velikov wrote: > From: Emil Velikov > > It's used only by dev_icd.json so just call it that way. While we're > here, manually expand $< (as it might cause issue on some systems) > and drop the unneeded install_libdir substitution. > > Cc: Jason Ekstran

Re: [Mesa-dev] [PATCH v2 03/25] anv: tweak the %.json rule

2016-04-22 Thread Jason Ekstrand
On Apr 22, 2016 11:05, "Emil Velikov" wrote: > > On 22 April 2016 at 18:58, Jason Ekstrand wrote: > > I'm not sure what I think of this. I don't think dev_icd is the only icd > > file we're going to need to build. Right now, we don't build the regular > > ICD but I think we want to eventually i

Re: [Mesa-dev] [PATCH v2 03/25] anv: tweak the %.json rule

2016-04-22 Thread Emil Velikov
On 22 April 2016 at 18:58, Jason Ekstrand wrote: > I'm not sure what I think of this. I don't think dev_icd is the only icd > file we're going to need to build. Right now, we don't build the regular > ICD but I think we want to eventually in which case having a general rule is > a good thing. >

Re: [Mesa-dev] [PATCH v2 03/25] anv: tweak the %.json rule

2016-04-22 Thread Jason Ekstrand
I'm not sure what I think of this. I don't think dev_icd is the only icd file we're going to need to build. Right now, we don't build the regular ICD but I think we want to eventually in which case having a general rule is a good thing. On Fri, Apr 22, 2016 at 11:55 AM, Emil Velikov wrote: > F

[Mesa-dev] [PATCH v2 03/25] anv: tweak the %.json rule

2016-04-22 Thread Emil Velikov
From: Emil Velikov It's used only by dev_icd.json so just call it that way. While we're here, manually expand $< (as it might cause issue on some systems) and drop the unneeded install_libdir substitution. Cc: Jason Ekstrand Signed-off-by: Emil Velikov --- This commit replaces "anv: remove no