Re: [Mesa-dev] [PATCH v2 03/14] glsl: Implement parser support for atomic counters.

2013-10-23 Thread Francisco Jerez
Thank you for your comments, I've rebased my atomic counters branch on top of master [1] and I think I've taken into account everything you had pointed out. The rebase has turned out to be especially painful this time. To avoid wasting more time rebasing patches that no-one is going to have a lo

Re: [Mesa-dev] [PATCH v2 03/14] glsl: Implement parser support for atomic counters.

2013-10-22 Thread Ian Romanick
On 10/01/2013 07:15 PM, Francisco Jerez wrote: > v2: Mark atomic counters as read-only variables. Move offset overlap > code to the linker. Use the contains_atomic() convenience method. > --- > src/glsl/ast.h| 15 > src/glsl/ast_to_hir.cpp | 57 > +

[Mesa-dev] [PATCH v2 03/14] glsl: Implement parser support for atomic counters.

2013-10-01 Thread Francisco Jerez
v2: Mark atomic counters as read-only variables. Move offset overlap code to the linker. Use the contains_atomic() convenience method. --- src/glsl/ast.h| 15 src/glsl/ast_to_hir.cpp | 57 ++- src/glsl/ast_type.cpp