Re: [Mesa-dev] [PATCH v2 00/16] ARB_gl_spirv series 3 v2: support for atomic counters

2018-07-03 Thread Alejandro Piñeiro
On 03/07/18 02:29, Timothy Arceri wrote: > Series looks good to me. Just pushed to master. Thanks! > How much to go before we can turn this extension on? TL; DR: In summary there is a lot already done, but there is still work to do. In general, we tried to cover as much features as possible, an

Re: [Mesa-dev] [PATCH v2 00/16] ARB_gl_spirv series 3 v2: support for atomic counters

2018-07-02 Thread Timothy Arceri
Series looks good to me. How much to go before we can turn this extension on? On 03/07/18 00:58, Alejandro Piñeiro wrote: Hi Timothy. Thanks for the quick review! As you suggested some squash and commit drops, Im resending the v2 of the series, just in case you want a final overview of the ser

Re: [Mesa-dev] [PATCH v2 00/16] ARB_gl_spirv series 3 v2: support for atomic counters

2018-07-02 Thread Alejandro Piñeiro
Forgot to CC Timothy. On 02/07/18 16:58, Alejandro Piñeiro wrote: > Hi Timothy. Thanks for the quick review! > > As you suggested some squash and commit drops, Im resending the v2 of > the series, just in case you want a final overview of the series > (although it is somewhat an overkill, I know)

[Mesa-dev] [PATCH v2 00/16] ARB_gl_spirv series 3 v2: support for atomic counters

2018-07-02 Thread Alejandro Piñeiro
Hi Timothy. Thanks for the quick review! As you suggested some squash and commit drops, Im resending the v2 of the series, just in case you want a final overview of the series (although it is somewhat an overkill, I know). The only patch missing a review is "[PATCH 13/16] nir: Fix OpAtomicCounter