Re: [Mesa-dev] [PATCH v2] radeon: Use upload manager for buffer downloads

2014-03-05 Thread Niels Ole Salscheider
On Tuesday 04 March 2014, 23:43:01, Marek Olšák wrote: > You check for streamout and CP DMA support, but you don't use > resource_copy_region if DMA is not supported. The CP DMA and > streamout-based buffer copying is only used by resource_copy_region. Oh, right. I initially used resource_copy_reg

Re: [Mesa-dev] [PATCH v2] radeon: Use upload manager for buffer downloads

2014-03-04 Thread Marek Olšák
You check for streamout and CP DMA support, but you don't use resource_copy_region if DMA is not supported. The CP DMA and streamout-based buffer copying is only used by resource_copy_region. The last parameter of buffer_wait should be RADEON_USAGE_WRITE (you're waiting for the last write to the s

[Mesa-dev] [PATCH v2] radeon: Use upload manager for buffer downloads

2014-03-04 Thread Niels Ole Salscheider
Using DMA for reads is much faster. Signed-off-by: Niels Ole Salscheider --- src/gallium/drivers/radeon/r600_buffer_common.c | 78 +++-- 1 file changed, 60 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c b/src/gallium/drivers/rade