Re: [Mesa-dev] [PATCH v2] r600g: allow viewport index/layer to be sent to fs

2014-07-02 Thread Ilia Mirkin
Thanks Tobias! I've pushed this change now. On Wed, Jul 2, 2014 at 12:49 AM, Tobias Droste wrote: > Hi, > > I did a piglit run with the gpu.py profile with and without the patch. > There were some switches from pass->fail and fail->pass in > spec/glsl-1.50/execution/geometry/end-primitive but the

Re: [Mesa-dev] [PATCH v2] r600g: allow viewport index/layer to be sent to fs

2014-07-01 Thread Tobias Droste
Hi, I did a piglit run with the gpu.py profile with and without the patch. There were some switches from pass->fail and fail->pass in spec/glsl-1.50/execution/geometry/end-primitive but these seem to not be stable, because after a second with and without a patch different tests from this catego

Re: [Mesa-dev] [PATCH v2] r600g: allow viewport index/layer to be sent to fs

2014-07-01 Thread Ilia Mirkin
On Tue, Jul 1, 2014 at 9:23 PM, Michel Dänzer wrote: > On 02.07.2014 01:25, Marek Olšák wrote: >> If the tests pass, the patch can be merged. > > And if the patch causes no piglit regressions. I can't vouch for that. I have a report that the ARB_fragment_layer_viewport-specific tests pass on a ca

Re: [Mesa-dev] [PATCH v2] r600g: allow viewport index/layer to be sent to fs

2014-07-01 Thread Michel Dänzer
On 02.07.2014 01:25, Marek Olšák wrote: > If the tests pass, the patch can be merged. And if the patch causes no piglit regressions. -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast |Mesa and X developer _

Re: [Mesa-dev] [PATCH v2] r600g: allow viewport index/layer to be sent to fs

2014-07-01 Thread Marek Olšák
If the tests pass, the patch can be merged. Marek On Tue, Jul 1, 2014 at 5:25 PM, Ilia Mirkin wrote: > On Tue, Jul 1, 2014 at 11:13 AM, Alex Deucher wrote: >> On Tue, Jun 24, 2014 at 8:43 PM, Ilia Mirkin wrote: >>> In order to support ARB_fragment_layer_viewport, we need to explicitly >>> send

Re: [Mesa-dev] [PATCH v2] r600g: allow viewport index/layer to be sent to fs

2014-07-01 Thread Ilia Mirkin
On Tue, Jul 1, 2014 at 11:13 AM, Alex Deucher wrote: > On Tue, Jun 24, 2014 at 8:43 PM, Ilia Mirkin wrote: >> In order to support ARB_fragment_layer_viewport, we need to explicitly >> send these along to the fragment shader, since it has no other way to >> retrieve them. >> >> Signed-off-by: Ilia

Re: [Mesa-dev] [PATCH v2] r600g: allow viewport index/layer to be sent to fs

2014-07-01 Thread Alex Deucher
On Tue, Jun 24, 2014 at 8:43 PM, Ilia Mirkin wrote: > In order to support ARB_fragment_layer_viewport, we need to explicitly > send these along to the fragment shader, since it has no other way to > retrieve them. > > Signed-off-by: Ilia Mirkin > Tested-by: Tobias Droste > --- > > v1 -> v2: > >

[Mesa-dev] [PATCH v2] r600g: allow viewport index/layer to be sent to fs

2014-06-24 Thread Ilia Mirkin
In order to support ARB_fragment_layer_viewport, we need to explicitly send these along to the fragment shader, since it has no other way to retrieve them. Signed-off-by: Ilia Mirkin Tested-by: Tobias Droste --- v1 -> v2: - Add forgotten copy to initialize new output with the settings of the