Re: [Mesa-dev] [PATCH v2] r600g: Implement ARB_draw_indirect for EG/CM

2014-12-13 Thread Marek Olšák
1) You're using magic numbers instead of the actual packet definitions. 2) index_bias and start is also set in vgt_indx_offset of vgt_state. This won't work if index_bias or start are non-zero. It should be set to zero for indirect drawing. Marek On Sat, Dec 13, 2014 at 3:40 AM, Glenn Kennard w

[Mesa-dev] [PATCH v2] r600g: Implement ARB_draw_indirect for EG/CM

2014-12-12 Thread Glenn Kennard
Requires Evergreen/Cayman and updated radeon kernel module Signed-off-by: Glenn Kennard --- Changes since V1: * Fixed 8 bit index case, only triggerable using GLES 3.1 which isn't supported yet * Don't read info struct values that have no meaning for indirect case * Don't update start_instance/i