Re: [Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c

2017-03-27 Thread Brian Paul
On 03/26/2017 08:54 PM, Edward O'Callaghan wrote: On 03/27/2017 01:49 PM, Brian Paul wrote: On Sun, Mar 26, 2017 at 5:51 PM, Edward O'Callaghan mailto:funfunc...@folklore1984.net>> wrote: V.1: We memset number of elements without multiplication by the element size. V.2:

Re: [Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c

2017-03-27 Thread Alejandro Piñeiro
On 27/03/17 09:19, Gustaw Smolarczyk wrote: > 27 mar 2017 08:47 "Alejandro Piñeiro" > napisał(a): > > On 27/03/17 01:51, Edward O'Callaghan wrote: > > V.1: > > We memset number of elements without multiplication by the > > element size. > > It is no

Re: [Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c

2017-03-27 Thread Gustaw Smolarczyk
27 mar 2017 08:47 "Alejandro Piñeiro" napisał(a): On 27/03/17 01:51, Edward O'Callaghan wrote: > V.1: > We memset number of elements without multiplication by the > element size. It is not usual to summarize v1. The idea is explain just the changes. > > V.2: > We explicitly set each member to -1

Re: [Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c

2017-03-26 Thread Alejandro Piñeiro
On 27/03/17 01:51, Edward O'Callaghan wrote: > V.1: > We memset number of elements without multiplication by the > element size. It is not usual to summarize v1. The idea is explain just the changes. > > V.2: > We explicitly set each member to -1 over using a confusing > memset(). Nitpick: usuall

Re: [Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c

2017-03-26 Thread Edward O'Callaghan
On 03/27/2017 01:49 PM, Brian Paul wrote: > On Sun, Mar 26, 2017 at 5:51 PM, Edward O'Callaghan > mailto:funfunc...@folklore1984.net>> wrote: > > V.1: > We memset number of elements without multiplication by the > element size. > > V.2: > We explicitly set each member to -1

Re: [Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c

2017-03-26 Thread Brian Paul
On Sun, Mar 26, 2017 at 5:51 PM, Edward O'Callaghan < funfunc...@folklore1984.net> wrote: > V.1: > We memset number of elements without multiplication by the > element size. > > V.2: > We explicitly set each member to -1 over using a confusing > memset(). > > Signed-off-by: Edward O'Callaghan > -

[Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c

2017-03-26 Thread Edward O'Callaghan
V.1: We memset number of elements without multiplication by the element size. V.2: We explicitly set each member to -1 over using a confusing memset(). Signed-off-by: Edward O'Callaghan --- src/mesa/main/formatquery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/