Re: [Mesa-dev] [PATCH v2] isl: remove ffs function that conflicts with system headers

2016-04-25 Thread Jonathan Gray
On Mon, Apr 25, 2016 at 04:36:44PM +0100, Emil Velikov wrote: > On 25 April 2016 at 16:07, Jonathan Gray wrote: > > On Mon, Apr 25, 2016 at 03:14:57PM +0100, Emil Velikov wrote: > >> On 23 April 2016 at 15:36, Jason Ekstrand wrote: > >> > Reviewed-by: Jason Ekstrand > >> > > >> And pushed. Thank

Re: [Mesa-dev] [PATCH v2] isl: remove ffs function that conflicts with system headers

2016-04-25 Thread Emil Velikov
On 25 April 2016 at 16:07, Jonathan Gray wrote: > On Mon, Apr 25, 2016 at 03:14:57PM +0100, Emil Velikov wrote: >> On 23 April 2016 at 15:36, Jason Ekstrand wrote: >> > Reviewed-by: Jason Ekstrand >> > >> And pushed. Thanks Jason. >> >> > In general, we should be using mesa compat headers for th

Re: [Mesa-dev] [PATCH v2] isl: remove ffs function that conflicts with system headers

2016-04-25 Thread Jonathan Gray
On Mon, Apr 25, 2016 at 03:14:57PM +0100, Emil Velikov wrote: > On 23 April 2016 at 15:36, Jason Ekstrand wrote: > > Reviewed-by: Jason Ekstrand > > > And pushed. Thanks Jason. > > > In general, we should be using mesa compat headers for this sort of thing > > rather than hand-rolling it. > > >

Re: [Mesa-dev] [PATCH v2] isl: remove ffs function that conflicts with system headers

2016-04-25 Thread Emil Velikov
On 23 April 2016 at 15:36, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > And pushed. Thanks Jason. > In general, we should be using mesa compat headers for this sort of thing > rather than hand-rolling it. > Fully agree with you here. Since ffs is c99 and all targets that mesa support ha

Re: [Mesa-dev] [PATCH v2] isl: remove ffs function that conflicts with system headers

2016-04-23 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand In general, we should be using mesa compat headers for this sort of thing rather than hand-rolling it. On Apr 23, 2016 12:28 AM, "Jonathan Gray" wrote: > Remove a wrapper around __builtin_ffs that conflicts with system > headers on OpenBSD and perhaps elsewhere: > >

[Mesa-dev] [PATCH v2] isl: remove ffs function that conflicts with system headers

2016-04-23 Thread Jonathan Gray
Remove a wrapper around __builtin_ffs that conflicts with system headers on OpenBSD and perhaps elsewhere: isl_priv.h:44: error: conflicting types for 'ffs' v2: include strings.h to ensure prototype is found Signed-off-by: Jonathan Gray --- src/intel/isl/isl_priv.h | 6 +- 1 file changed,