Re: [Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

2018-01-12 Thread Samuel Iglesias Gonsálvez
On 11/01/18 23:27, Jason Ekstrand wrote: > Sorry.  It's taken a bit of time but the WG has a decision and that is > that we are supposed to throw VK_ERROR_OUT_OF_DEVICE_MEMORY in this > case.  I believe you had an alternate version of the patch that did > something like that.  If so, we should re

Re: [Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

2018-01-11 Thread Jason Ekstrand
Sorry. It's taken a bit of time but the WG has a decision and that is that we are supposed to throw VK_ERROR_OUT_OF_DEVICE_MEMORY in this case. I believe you had an alternate version of the patch that did something like that. If so, we should revive it. On Thu, Jan 11, 2018 at 5:04 AM, Samuel I

Re: [Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

2018-01-11 Thread Samuel Iglesias Gonsálvez
This patch is still unreviewed. Sam On 14/11/17 09:45, Samuel Iglesias Gonsálvez wrote: > The HW has some limits but, according to the spec, we can create > the image as it has not yet any memory backing it. This patch > logs a debug error and set the size to the UINT64_MAX in order to > avoid a

Re: [Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

2017-12-11 Thread Samuel Iglesias Gonsálvez
On 28/11/17 11:07, Samuel Iglesias Gonsálvez wrote: > This patch is still unreviewed. > Gently reminder. Sam > Sam > > On Tue, 2017-11-14 at 09:45 +0100, Samuel Iglesias Gonsálvez wrote: >> The HW has some limits but, according to the spec, we can create >> the image as it has not yet any memo

Re: [Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

2017-11-28 Thread Samuel Iglesias Gonsálvez
This patch is still unreviewed. Sam On Tue, 2017-11-14 at 09:45 +0100, Samuel Iglesias Gonsálvez wrote: > The HW has some limits but, according to the spec, we can create > the image as it has not yet any memory backing it. This patch > logs a debug error and set the size to the UINT64_MAX in ord

[Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

2017-11-14 Thread Samuel Iglesias Gonsálvez
The HW has some limits but, according to the spec, we can create the image as it has not yet any memory backing it. This patch logs a debug error and set the size to the UINT64_MAX in order to avoid allocating actual memory later. Fixes the crashes on BDW for the following tests: dEQP-VK.pipeline