Re: [Mesa-dev] [PATCH v2] i965: fix textureGrad for cubemaps

2015-09-18 Thread Iago Toral
On Fri, 2015-09-18 at 15:02 +0300, Tapani Pälli wrote: > Fixes bugs exposed by commit > 2b1cdb0eddb73f62e4848d4b64840067f1f70865 in: >ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_frag > > No regressions observed in deqp, CTS or Piglit. > > v2: address review feedback from Iago Toral: >- m

[Mesa-dev] [PATCH v2] i965: fix textureGrad for cubemaps

2015-09-18 Thread Tapani Pälli
Fixes bugs exposed by commit 2b1cdb0eddb73f62e4848d4b64840067f1f70865 in: ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_frag No regressions observed in deqp, CTS or Piglit. v2: address review feedback from Iago Toral: - move rho calculation to else branch - optimize dx and dy calculation