Re: [Mesa-dev] [PATCH v2] i965: Refactor image uniform setup

2015-08-19 Thread Jason Ekstrand
On Wed, Aug 19, 2015 at 6:48 AM, Jason Ekstrand wrote: > > On Aug 19, 2015 6:45 AM, "Francisco Jerez" wrote: >> >> Jason Ekstrand writes: >> >> > On Aug 19, 2015 2:56 AM, "Francisco Jerez" >> > wrote: >> >> >> >> Jason Ekstrand writes: >> >> >> >> > Previously, setting up image uniforms relied

Re: [Mesa-dev] [PATCH v2] i965: Refactor image uniform setup

2015-08-19 Thread Jason Ekstrand
On Aug 19, 2015 6:45 AM, "Francisco Jerez" wrote: > > Jason Ekstrand writes: > > > On Aug 19, 2015 2:56 AM, "Francisco Jerez" wrote: > >> > >> Jason Ekstrand writes: > >> > >> > Previously, setting up image uniforms relied on being called after > >> > fs_visitor::uniforms was set and with fs_vi

Re: [Mesa-dev] [PATCH v2] i965: Refactor image uniform setup

2015-08-19 Thread Francisco Jerez
Jason Ekstrand writes: > On Aug 19, 2015 2:56 AM, "Francisco Jerez" wrote: >> >> Jason Ekstrand writes: >> >> > Previously, setting up image uniforms relied on being called after >> > fs_visitor::uniforms was set and with fs_visitor::uniforms not > allocating >> > space for it. This made sense

Re: [Mesa-dev] [PATCH v2] i965: Refactor image uniform setup

2015-08-19 Thread Jason Ekstrand
On Aug 19, 2015 2:56 AM, "Francisco Jerez" wrote: > > Jason Ekstrand writes: > > > Previously, setting up image uniforms relied on being called after > > fs_visitor::uniforms was set and with fs_visitor::uniforms not allocating > > space for it. This made sense in an ir_visitor world because the

Re: [Mesa-dev] [PATCH v2] i965: Refactor image uniform setup

2015-08-19 Thread Francisco Jerez
Jason Ekstrand writes: > Previously, setting up image uniforms relied on being called after > fs_visitor::uniforms was set and with fs_visitor::uniforms not allocating > space for it. This made sense in an ir_visitor world because the visitor > assigns locations and uploads data as it walks thro

[Mesa-dev] [PATCH v2] i965: Refactor image uniform setup

2015-08-18 Thread Jason Ekstrand
Previously, setting up image uniforms relied on being called after fs_visitor::uniforms was set and with fs_visitor::uniforms not allocating space for it. This made sense in an ir_visitor world because the visitor assigns locations and uploads data as it walks through the variables. In NIR it als