Re: [Mesa-dev] [PATCH v2] glsl: Correct several built-in functions availability

2018-11-08 Thread Timothy Arceri
On 2/11/18 6:41 am, Ian Romanick wrote: On 10/31/2018 03:05 PM, Timothy Arceri wrote: If we are going to start tightening up this stuff I would really really like to see CTS tests (not piglit tests) to go along with this stuff. We are already way stricter with these type of things than the clos

Re: [Mesa-dev] [PATCH v2] glsl: Correct several built-in functions availability

2018-11-01 Thread Ian Romanick
On 10/31/2018 03:05 PM, Timothy Arceri wrote: > If we are going to start tightening up this stuff I would really really > like to see CTS tests (not piglit tests) to go along with this stuff. > > We are already way stricter with these type of things than the closed > source drivers and this leads

Re: [Mesa-dev] [PATCH v2] glsl: Correct several built-in functions availability

2018-10-31 Thread Timothy Arceri
If we are going to start tightening up this stuff I would really really like to see CTS tests (not piglit tests) to go along with this stuff. We are already way stricter with these type of things than the closed source drivers and this leads to some apps not working. Before we go ahead and tig

[Mesa-dev] [PATCH v2] glsl: Correct several built-in functions availability

2018-10-31 Thread Vadym Shovkoplias
In GLSL versions 1.00 ES, 1.10 and 1.20, Mesa includes some built-in functions which shouldn't be present in that version, namely: genIType abs(genIType x) genIType sign(genIType x) genIType min(genIType x, genIType y) genIType min(genIType x, int y) genIType max(genIType x, genITyp