Re: [Mesa-dev] [PATCH v2] gallium/hud: control visibility at startup and runtime.

2015-11-04 Thread Jimmy Berry
Hi, Changes are straightforward and make sense. I had a followup on one. On Wed, Nov 4, 2015 at 10:14 AM, Mike Lothian wrote: > Hi > > On Wed, 4 Nov 2015, 8:53 a.m. Samuel Pitoiset > wrote: > > Hi Jimmy, > > Some comments below. > > On 11/04/2015 06:17 AM, Jimmy Berry wrote: >> - env GALLIUM_H

Re: [Mesa-dev] [PATCH v2] gallium/hud: control visibility at startup and runtime.

2015-11-04 Thread Mike Lothian
Hi On Wed, 4 Nov 2015, 8:53 a.m. Samuel Pitoiset wrote: Hi Jimmy, Some comments below. On 11/04/2015 06:17 AM, Jimmy Berry wrote: > - env GALLIUM_HUD_VISIBLE: control default visibility > - env GALLIUM_HUD_SIGNAL_TOGGLE: toggle visibility via signal > --- > Thanks for the feedback. > > I belie

Re: [Mesa-dev] [PATCH v2] gallium/hud: control visibility at startup and runtime.

2015-11-04 Thread Samuel Pitoiset
Hi Jimmy, Some comments below. On 11/04/2015 06:17 AM, Jimmy Berry wrote: - env GALLIUM_HUD_VISIBLE: control default visibility - env GALLIUM_HUD_SIGNAL_TOGGLE: toggle visibility via signal --- Thanks for the feedback. I believe all the suggested changes have been implemented. One note, all t

[Mesa-dev] [PATCH v2] gallium/hud: control visibility at startup and runtime.

2015-11-03 Thread Jimmy Berry
- env GALLIUM_HUD_VISIBLE: control default visibility - env GALLIUM_HUD_SIGNAL_TOGGLE: toggle visibility via signal --- Thanks for the feedback. I believe all the suggested changes have been implemented. One note, all the logic except for the toggle was already in hud_create() and not hud_draw().