Re: [Mesa-dev] [PATCH v2] ac/nir: set lod to 0 for ac_image_load_mip

2018-04-27 Thread Samuel Pitoiset
On 04/27/2018 10:50 AM, Nicolai Hähnle wrote: On 27.04.2018 10:05, Samuel Pitoiset wrote: On 04/26/2018 01:51 PM, Nicolai Hähnle wrote: Is there any reason why we can't just use ac_image_load in such cases? For nit_texop_txf_ms we need one more coordinate for the sample index, if we use ac

Re: [Mesa-dev] [PATCH v2] ac/nir: set lod to 0 for ac_image_load_mip

2018-04-27 Thread Nicolai Hähnle
On 27.04.2018 10:05, Samuel Pitoiset wrote: On 04/26/2018 01:51 PM, Nicolai Hähnle wrote: Is there any reason why we can't just use ac_image_load in such cases? For nit_texop_txf_ms we need one more coordinate for the sample index, if we use ac_image_load we only loads 2 coordinates instead o

Re: [Mesa-dev] [PATCH v2] ac/nir: set lod to 0 for ac_image_load_mip

2018-04-27 Thread Samuel Pitoiset
On 04/26/2018 01:51 PM, Nicolai Hähnle wrote: Is there any reason why we can't just use ac_image_load in such cases? For nit_texop_txf_ms we need one more coordinate for the sample index, if we use ac_image_load we only loads 2 coordinates instead of 4 with ac_image_load_mip. Though, I have

Re: [Mesa-dev] [PATCH v2] ac/nir: set lod to 0 for ac_image_load_mip

2018-04-26 Thread Nicolai Hähnle
Is there any reason why we can't just use ac_image_load in such cases? On 26.04.2018 13:18, Samuel Pitoiset wrote: Otherwise we hit an assertion in ac_build_image_opcode() for ac_image_load_mip. v2: - set only for ac_image_load_mip Fixes: 24fb3e6aa16 ("ac/nir: use ac_build_image_opcode for ima

[Mesa-dev] [PATCH v2] ac/nir: set lod to 0 for ac_image_load_mip

2018-04-26 Thread Samuel Pitoiset
Otherwise we hit an assertion in ac_build_image_opcode() for ac_image_load_mip. v2: - set only for ac_image_load_mip Fixes: 24fb3e6aa16 ("ac/nir: use ac_build_image_opcode for image intrinsics") Cc: 18.1 Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 2 ++ 1 file changed,