Re: [Mesa-dev] [PATCH mesa v2] i965: searching the cache doesn't need to modify it

2018-10-02 Thread Kenneth Graunke
The best way to make this code more readable is to replace it entirely. It's horribly overcomplicated for what is basically an open-coded hash table. I've had various starts at that...but never quite managed to finish. :( You could probably grab iris_program_cache.c from my iris branch, make it w

Re: [Mesa-dev] [PATCH mesa v2] i965: searching the cache doesn't need to modify it

2018-10-02 Thread Eric Engestrom
Ping? I'm just adding `const` to make it easier to read and understand the code, and allow the compiler to tell us if we make a mistake and start modifying things shouldn't. On Tuesday, 2018-08-07 12:02:53 +0100, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > v2: forgot the hunk th

[Mesa-dev] [PATCH mesa v2] i965: searching the cache doesn't need to modify it

2018-08-07 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- v2: forgot the hunk that was the point of this :facepalm: --- src/mesa/drivers/dri/i965/brw_program_cache.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_program_cache.c b/src/mesa/drivers/dri/i965