Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

2018-06-11 Thread Keith Packard
Jason Ekstrand writes: > Sorry for the multitude of replies. :-( It's all the same to me; you've been busy! >>radv_wsi_proc_addr, >> - &physical_device->instance->alloc); >> + &physical_device->instance->a

Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

2018-06-11 Thread Keith Packard
Jason Ekstrand writes: > If you move the VK_OUTARRAY_MAKE up higher, both of the "goto bail"s can be > "return vk_outarray_status(&conn)". Not a big deal though; what you have > is probably fine. I'll leave it then. >> +prop->currentStackIndex = stack_index++; >> > > In your branch

Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

2018-06-11 Thread Keith Packard
Jason Ekstrand writes: > I apologize for how nit-picky this is going to get but it's starting to > bother me... I'm glad you showed me what you wanted; always nice to have help! I've reformatted and restructured the code along the lines that you've suggested here for the entire series. In partic

Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

2018-06-11 Thread Keith Packard
Eric Engestrom writes: > I just pushed it; your `if (result != VK_SUCCESS)` should now just be > `goto fail;` :) Yup, I've update my drm-lease branch to match. -- -keith signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@li

Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

2018-04-09 Thread Jason Ekstrand
Sorry for the multitude of replies. :-( On Wed, Mar 7, 2018 at 11:24 PM, Keith Packard wrote: > This adds support for the KHR_display extension support to the vulkan > WSI layer. Driver support will be added separately. > > v2: > * fix double ;; in wsi_common_display.c > > * Move

Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

2018-04-09 Thread Jason Ekstrand
On Wed, Mar 7, 2018 at 11:24 PM, Keith Packard wrote: > > +/* > + * Implement vkGetPhysicalDeviceDisplayPropertiesKHR (VK_KHR_display) > + */ > +VkResult > +wsi_display_get_physical_device_display_properties(VkPhysicalDevice >physical_device, > +

Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

2018-03-09 Thread Eric Engestrom
On Thursday, 2018-03-08 10:04:03 -0800, Keith Packard wrote: > Eric Engestrom writes: > > > I'm still slightly bothered by the build options inconsistency between > > autotools: reuse --with-platform=drm > > meson: new -D platform=display > > > > I'd be happy with either one being used

Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

2018-03-08 Thread Keith Packard
Eric Engestrom writes: > I'm still slightly bothered by the build options inconsistency between > autotools: reuse --with-platform=drm > meson: new -D platform=display > > I'd be happy with either one being used everywhere, but from what you > said last time I think you'd prefer to reus

Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

2018-03-08 Thread Eric Engestrom
On Wednesday, 2018-03-07 23:24:59 -0800, Keith Packard wrote: > This adds support for the KHR_display extension support to the vulkan > WSI layer. Driver support will be added separately. > > v2: > * fix double ;; in wsi_common_display.c > > * Move mode list from wsi_display to wsi_di

[Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

2018-03-07 Thread Keith Packard
This adds support for the KHR_display extension support to the vulkan WSI layer. Driver support will be added separately. v2: * fix double ;; in wsi_common_display.c * Move mode list from wsi_display to wsi_display_connector * Fix scope for wsi_display_mode andwsi_display