Re: [Mesa-dev] [PATCH mesa] glsl: compile unused function out

2017-09-13 Thread Eric Engestrom
On Wednesday, 2017-09-13 17:24:57 +0200, Nicolai Hähnle wrote: > On 12.09.2017 17:01, Eric Engestrom wrote: > > The function is only called from one place, which is hidden behind > > the same `#ifdef DEBUG`. > > > > Fixes: ca73c3358c91434e68ab "glsl: Mark functions static" > > Signed-off-by: Eric

Re: [Mesa-dev] [PATCH mesa] glsl: compile unused function out

2017-09-13 Thread Nicolai Hähnle
On 12.09.2017 17:01, Eric Engestrom wrote: The function is only called from one place, which is hidden behind the same `#ifdef DEBUG`. Fixes: ca73c3358c91434e68ab "glsl: Mark functions static" Signed-off-by: Eric Engestrom Is there an alternative way to do that, perhaps using the MAYBE_UNUSED

Re: [Mesa-dev] [PATCH mesa] glsl: compile unused function out

2017-09-12 Thread Matt Turner
On Tue, Sep 12, 2017 at 8:01 AM, Eric Engestrom wrote: > The function is only called from one place, which is hidden behind > the same `#ifdef DEBUG`. > > Fixes: ca73c3358c91434e68ab "glsl: Mark functions static" > Signed-off-by: Eric Engestrom As long as make check continues passing (I broke th

[Mesa-dev] [PATCH mesa] glsl: compile unused function out

2017-09-12 Thread Eric Engestrom
The function is only called from one place, which is hidden behind the same `#ifdef DEBUG`. Fixes: ca73c3358c91434e68ab "glsl: Mark functions static" Signed-off-by: Eric Engestrom --- src/compiler/glsl/ir_validate.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/glsl/ir_val