Re: [Mesa-dev] [PATCH mesa] gallium/cso: avoid unnecessary null dereference

2016-07-13 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jul 12, 2016 at 11:48 PM, Eric Engestrom wrote: > The label `out:` calls `destroy()` which dereferences `ctx`. > This is unnecessary as there is nothing to destroy. > Immediately return instead. > > CovID: 1258255 > Signed-off-by: Eric Engestrom > --- >

Re: [Mesa-dev] [PATCH mesa] gallium/cso: avoid unnecessary null dereference

2016-07-13 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 12.07.2016 23:48, Eric Engestrom wrote: The label `out:` calls `destroy()` which dereferences `ctx`. This is unnecessary as there is nothing to destroy. Immediately return instead. CovID: 1258255 Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/cso_cach

[Mesa-dev] [PATCH mesa] gallium/cso: avoid unnecessary null dereference

2016-07-12 Thread Eric Engestrom
The label `out:` calls `destroy()` which dereferences `ctx`. This is unnecessary as there is nothing to destroy. Immediately return instead. CovID: 1258255 Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/cso_cache/cso_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff