Re: [Mesa-dev] [PATCH V5 7/7] intel: implement create image from texture

2013-01-23 Thread Eric Anholt
Abdiel Janulgue writes: > On Tuesday, January 22, 2013 11:02:34 AM Eric Anholt wrote: > >> 128 pixels of 32bpp is a tile width, and 128 pixels high of that is 16 >> tiles. The values I see this function having are: >> >> mask_x = 127 >> mask_y = 15 >> draw_x = 0 >> draw_y = 128 >> image->offset

Re: [Mesa-dev] [PATCH V5 7/7] intel: implement create image from texture

2013-01-23 Thread Abdiel Janulgue
On Tuesday, January 22, 2013 11:02:34 AM Eric Anholt wrote: > 128 pixels of 32bpp is a tile width, and 128 pixels high of that is 16 > tiles. The values I see this function having are: > > mask_x = 127 > mask_y = 15 > draw_x = 0 > draw_y = 128 > image->offset = (16 * 4096) > > So when we go to

Re: [Mesa-dev] [PATCH V5 7/7] intel: implement create image from texture

2013-01-22 Thread Eric Anholt
Abdiel Janulgue writes: > @@ -295,6 +301,95 @@ intel_allocate_image(int dri_format, void *loaderPrivate) > return image; > } > > +/** > + * Save appropriately-aligned base offset pointing to the image > + * in addition to the x/y offsets from miptree's base address. > + * The fine adjustme

[Mesa-dev] [PATCH V5 7/7] intel: implement create image from texture

2013-01-17 Thread Abdiel Janulgue
Save miptree level info to DRIImage: - Appropriately-aligned base offset pointing to the image - x/y offsets from miptree's base address In non-tile-aligned surface cases where resolving back to the original image located in mip-levels higher than the base level proves problematic due to offset al