Re: [Mesa-dev] [PATCH V2 4/8] mesa: stop passing state bitfield to UpdateState()

2017-06-08 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 06/08/2017 01:39 AM, Timothy Arceri wrote: The code comment which seems to have been added in cab974cf6c2db (from year 2000) says: "Set ctx->NewState to zero to avoid recursion if Driver.UpdateState() has to call FLUSH_VERTICES(). (fixed?)" As far as I

Re: [Mesa-dev] [PATCH V2 4/8] mesa: stop passing state bitfield to UpdateState()

2017-06-07 Thread Brian Paul
Reviewed-by: Brian Paul On 06/07/2017 05:39 PM, Timothy Arceri wrote: The code comment which seems to have been added in cab974cf6c2db (from year 2000) says: "Set ctx->NewState to zero to avoid recursion if Driver.UpdateState() has to call FLUSH_VERTICES(). (fixed?)" As far as I can

[Mesa-dev] [PATCH V2 4/8] mesa: stop passing state bitfield to UpdateState()

2017-06-07 Thread Timothy Arceri
The code comment which seems to have been added in cab974cf6c2db (from year 2000) says: "Set ctx->NewState to zero to avoid recursion if Driver.UpdateState() has to call FLUSH_VERTICES(). (fixed?)" As far as I can tell nothing in any of the UpdateState() calls should cause it to be called