Re: [Mesa-dev] [PATCH V2 3/8] glsl: Add array specifier to ast code

On 21 January 2014 14:54, Timothy Arceri wrote: > Hi Paul > > Thanks for the thorough review and taking the time to explain how to make > improvements. I can already see a number of improvements that can be made > to patch 5 based on the suggestions you have already made so you could hold > off r

Re: [Mesa-dev] [PATCH V2 3/8] glsl: Add array specifier to ast code

Hi Paul Thanks for the thorough review and taking the time to explain how to make improvements. I can already see a number of improvements that can be made to patch 5 based on the suggestions you have already made so you could hold off reviewing that one if you havent started already and I've p

Re: [Mesa-dev] [PATCH V2 3/8] glsl: Add array specifier to ast code

On 21 January 2014 04:19, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > src/glsl/ast.h | 44 +++ > src/glsl/ast_array_index.cpp| 13 > src/glsl/ast_to_hir.cpp | 160 > +++- > src/glsl/ast_type.cpp

[Mesa-dev] [PATCH V2 3/8] glsl: Add array specifier to ast code

Signed-off-by: Timothy Arceri --- src/glsl/ast.h | 44 +++ src/glsl/ast_array_index.cpp| 13 src/glsl/ast_to_hir.cpp | 160 +++- src/glsl/ast_type.cpp | 8 +- src/glsl/glsl_parser_extras.cpp | 30