Re: [Mesa-dev] [PATCH V2 1/3] glsl: move array validation into its own function

2015-03-02 Thread Mark Janes
The series is Reviewed-by: Mark Janes Timothy Arceri writes: > V2: return true when var->type is unsized by max access is within valid range > > --- > src/glsl/linker.cpp | 89 > ++--- > src/glsl/linker.h | 5 +++ > 2 files changed, 55 inse

Re: [Mesa-dev] [PATCH V2 1/3] glsl: move array validation into its own function

2015-02-27 Thread Timothy Arceri
On Fri, 2015-02-27 at 11:59 -0800, Matt Turner wrote: > On Wed, Feb 25, 2015 at 11:45 PM, Timothy Arceri > wrote: > > V2: return true when var->type is unsized by max access is within valid > > range > > > > --- > > src/glsl/linker.cpp | 89 > > ++---

Re: [Mesa-dev] [PATCH V2 1/3] glsl: move array validation into its own function

2015-02-27 Thread Matt Turner
On Wed, Feb 25, 2015 at 11:45 PM, Timothy Arceri wrote: > V2: return true when var->type is unsized by max access is within valid range > > --- > src/glsl/linker.cpp | 89 > ++--- > src/glsl/linker.h | 5 +++ > 2 files changed, 55 insertions(+),

Re: [Mesa-dev] [PATCH V2 1/3] glsl: move array validation into its own function

2015-02-25 Thread Timothy Arceri
On Thu, 2015-02-26 at 18:45 +1100, Timothy Arceri wrote: > V2: return true when var->type is unsized by max access is within valid range That should be: V2: return true when var->type is unsized but max access is within valid range Fixed in my local branch > __

[Mesa-dev] [PATCH V2 1/3] glsl: move array validation into its own function

2015-02-25 Thread Timothy Arceri
V2: return true when var->type is unsized by max access is within valid range --- src/glsl/linker.cpp | 89 ++--- src/glsl/linker.h | 5 +++ 2 files changed, 55 insertions(+), 39 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cp