Re: [Mesa-dev] [PATCH 8/8] radeonsi: don't update dependent states if it has no effect

2017-06-07 Thread Samuel Pitoiset
On 06/07/2017 02:34 PM, Nicolai Hähnle wrote: On 06.06.2017 21:16, Samuel Pitoiset wrote: I really like the idea. :-) Seconded! Though, I have two general comments: 1) I think it would be better to introduce some sort of compare helper functions for the different state changes. Also, fo

Re: [Mesa-dev] [PATCH 8/8] radeonsi: don't update dependent states if it has no effect

2017-06-07 Thread Marek Olšák
On Wed, Jun 7, 2017 at 2:34 PM, Nicolai Hähnle wrote: > On 06.06.2017 21:16, Samuel Pitoiset wrote: >> >> I really like the idea. :-) > > > Seconded! > > >> Though, I have two general comments: >> >> 1) I think it would be better to introduce some sort of compare helper >> functions for the differ

Re: [Mesa-dev] [PATCH 8/8] radeonsi: don't update dependent states if it has no effect

2017-06-07 Thread Nicolai Hähnle
On 06.06.2017 21:16, Samuel Pitoiset wrote: I really like the idea. :-) Seconded! Though, I have two general comments: 1) I think it would be better to introduce some sort of compare helper functions for the different state changes. Also, for correctness it might be safer to do the opposi

Re: [Mesa-dev] [PATCH 8/8] radeonsi: don't update dependent states if it has no effect

2017-06-06 Thread Samuel Pitoiset
I really like the idea. :-) Though, I have two general comments: 1) I think it would be better to introduce some sort of compare helper functions for the different state changes. Also, for correctness it might be safer to do the opposite checks (if someone introduce a new field and forget to

[Mesa-dev] [PATCH 8/8] radeonsi: don't update dependent states if it has no effect

2017-06-05 Thread Marek Olšák
From: Marek Olšák This and the previous commit decrease IB sizes and the number of si_update_shaders invocations as follows: IB size si_update_shader calls Borderlands 2 -10%-27% Deus Ex: MD -5%-11% Talos Principle -8%-30% -