Re: [Mesa-dev] [PATCH 7/8] i965/vec4: Allow constant propagation of VF immediates.

2014-12-23 Thread Matt Turner
On 12/22/14, Ian Romanick wrote: > On 12/21/2014 03:24 PM, Matt Turner wrote: >> + } else if (value.type == BRW_REGISTER_TYPE_VF) { >> + value.fixed_hw_reg.dw1.ud &= ~0x80808080; > > What's the magic constant? Sign bits of all the vector float values? Yes. The 32-bit VF immediate co

Re: [Mesa-dev] [PATCH 7/8] i965/vec4: Allow constant propagation of VF immediates.

2014-12-22 Thread Ian Romanick
On 12/21/2014 03:24 PM, Matt Turner wrote: > total instructions in shared programs: 5877951 -> 5877012 (-0.02%) > instructions in affected programs: 155923 -> 154984 (-0.60%) > > Helps 1233, hurts 156 shaders. The hurt shaders are addressed in the > next commit. > --- > .../drivers/dri/i965/b

[Mesa-dev] [PATCH 7/8] i965/vec4: Allow constant propagation of VF immediates.

2014-12-21 Thread Matt Turner
total instructions in shared programs: 5877951 -> 5877012 (-0.02%) instructions in affected programs: 155923 -> 154984 (-0.60%) Helps 1233, hurts 156 shaders. The hurt shaders are addressed in the next commit. --- .../drivers/dri/i965/brw_vec4_copy_propagation.cpp | 28 +-