Re: [Mesa-dev] [PATCH 7/7] util/disk_cache: hash pointer size into cache keys

2017-03-12 Thread Timothy Arceri
On 13/03/17 09:34, Grazvydas Ignotas wrote: On Mon, Mar 13, 2017 at 12:20 AM, Timothy Arceri wrote: We don't need to hash the pointer size. You can just remove get_arch_bitness_str() and fix up the test. Timestamp should be enough on its own, even if the 64/32bit builds have the same timestam

Re: [Mesa-dev] [PATCH 7/7] util/disk_cache: hash pointer size into cache keys

2017-03-12 Thread Grazvydas Ignotas
On Mon, Mar 13, 2017 at 12:20 AM, Timothy Arceri wrote: > We don't need to hash the pointer size. You can just remove > get_arch_bitness_str() and fix up the test. Timestamp should be enough on > its own, even if the 64/32bit builds have the same timestamp that is fine > because the cache entries

Re: [Mesa-dev] [PATCH 7/7] util/disk_cache: hash pointer size into cache keys

2017-03-12 Thread Timothy Arceri
We don't need to hash the pointer size. You can just remove get_arch_bitness_str() and fix up the test. Timestamp should be enough on its own, even if the 64/32bit builds have the same timestamp that is fine because the cache entries are arch independent. The only reason for the arch dir was t

[Mesa-dev] [PATCH 7/7] util/disk_cache: hash pointer size into cache keys

2017-03-12 Thread Grazvydas Ignotas
This allows to get rid of the arch directory. It also hashes sizeof(long) just in case disk_cache ever ends being up used on Windows. Signed-off-by: Grazvydas Ignotas --- src/compiler/glsl/tests/cache_test.c | 13 ++--- src/util/disk_cache.c| 15 ++- src/util/