Re: [Mesa-dev] [PATCH 7/7] radeonsi: Enable ARB_framebuffer_no_attachments

2016-02-03 Thread Marek Olšák
On Wed, Feb 3, 2016 at 1:09 PM, Ilia Mirkin wrote: > I've sent a few tests to cover samples, but haven't quite been able to work > out the implication of layered vs non. I guess the main thing is to assure that primitives with gl_Layer >= 0 aren't discarded by the rasterizer. Marek _

Re: [Mesa-dev] [PATCH 7/7] radeonsi: Enable ARB_framebuffer_no_attachments

2016-02-03 Thread Ilia Mirkin
I've sent a few tests to cover samples, but haven't quite been able to work out the implication of layered vs non. On Feb 3, 2016 4:18 AM, "Marek Olšák" wrote: > Actually, it seems enough, but it's hard to tell without tests. > > Marek > > On Wed, Feb 3, 2016 at 10:16 AM, Marek Olšák wrote: > >

Re: [Mesa-dev] [PATCH 7/7] radeonsi: Enable ARB_framebuffer_no_attachments

2016-02-03 Thread Marek Olšák
Actually, it seems enough, but it's hard to tell without tests. Marek On Wed, Feb 3, 2016 at 10:16 AM, Marek Olšák wrote: > I think this is not enough. Do we even have layered rendering and > sample shading tests with no attachments? > > Marek > > On Sun, Jan 31, 2016 at 7:25 AM, Edward O'Callag

Re: [Mesa-dev] [PATCH 7/7] radeonsi: Enable ARB_framebuffer_no_attachments

2016-02-03 Thread Marek Olšák
I think this is not enough. Do we even have layered rendering and sample shading tests with no attachments? Marek On Sun, Jan 31, 2016 at 7:25 AM, Edward O'Callaghan wrote: > Signed-off-by: Edward O'Callaghan > --- > src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- > 1 file changed, 3 insertio

[Mesa-dev] [PATCH 7/7] radeonsi: Enable ARB_framebuffer_no_attachments

2016-01-30 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index f219bc4..ffc25fb 100644 --- a/src/gallium/drivers/radeonsi/si_