Re: [Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

2016-10-07 Thread Chad Versace
On Wed 05 Oct 2016, Emil Velikov wrote: > On 4 October 2016 at 22:31, Chad Versace wrote: > > On Thu 29 Sep 2016, Emil Velikov wrote: > >> On 28 September 2016 at 07:28, Chad Versace > >> wrote: > >> > Pre-patch, there were two code paths for parsing EGLSync attribute > >> > lists: one path for

Re: [Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

2016-10-05 Thread Emil Velikov
On 4 October 2016 at 22:31, Chad Versace wrote: > On Thu 29 Sep 2016, Emil Velikov wrote: >> On 28 September 2016 at 07:28, Chad Versace wrote: >> > Pre-patch, there were two code paths for parsing EGLSync attribute >> > lists: one path for old-style EGLint lists, used by eglCreateSyncKHR, >> > a

Re: [Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

2016-10-04 Thread Chad Versace
On Thu 29 Sep 2016, Emil Velikov wrote: > On 28 September 2016 at 07:28, Chad Versace wrote: > > Pre-patch, there were two code paths for parsing EGLSync attribute > > lists: one path for old-style EGLint lists, used by eglCreateSyncKHR, > > and another for new-style EGLAttrib lists, used by eglCr

Re: [Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

2016-10-04 Thread Chad Versace
On Thu 29 Sep 2016, Emil Velikov wrote: > On 28 September 2016 at 07:28, Chad Versace wrote: > > > + if (sizeof(int_list[0]) == sizeof(attrib_list[0])) { > > + attrib_list = (EGLAttrib *) int_list; > > + } else { > > + err = _eglConvertIntsToAttribs(int_list, &attrib_list); > > +

Re: [Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

2016-09-29 Thread Emil Velikov
On 28 September 2016 at 07:28, Chad Versace wrote: > Pre-patch, there were two code paths for parsing EGLSync attribute > lists: one path for old-style EGLint lists, used by eglCreateSyncKHR, > and another for new-style EGLAttrib lists, used by eglCreateSync (1.5) > and eglCreateSync64 (EGL_KHR_cl

Re: [Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

2016-09-29 Thread Emil Velikov
On 28 September 2016 at 07:28, Chad Versace wrote: > + if (sizeof(int_list[0]) == sizeof(attrib_list[0])) { > + attrib_list = (EGLAttrib *) int_list; > + } else { > + err = _eglConvertIntsToAttribs(int_list, &attrib_list); > + if (err != EGL_SUCCESS) > + RETURN_EGL_ERRO

[Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

2016-09-27 Thread Chad Versace
Pre-patch, there were two code paths for parsing EGLSync attribute lists: one path for old-style EGLint lists, used by eglCreateSyncKHR, and another for new-style EGLAttrib lists, used by eglCreateSync (1.5) and eglCreateSync64 (EGL_KHR_cl_event2). There were two attrib_list parsing functions, _