Re: [Mesa-dev] [PATCH 6/9] i965/vec4: Use NIR remapping for VS attributes

2017-05-06 Thread Kenneth Graunke
On Saturday, May 6, 2017 11:13:37 AM PDT Jason Ekstrand wrote: > On May 5, 2017 4:30:31 PM Kenneth Graunke wrote: > > > On Friday, May 5, 2017 12:31:40 PM PDT Jason Ekstrand wrote: > >> On Fri, May 5, 2017 at 12:38 AM, Alejandro Piñeiro > >> wrote: > >> > >> > On 05/05/17 04:11, Jason Ekstrand w

Re: [Mesa-dev] [PATCH 6/9] i965/vec4: Use NIR remapping for VS attributes

2017-05-06 Thread Jason Ekstrand
On May 5, 2017 4:30:31 PM Kenneth Graunke wrote: On Friday, May 5, 2017 12:31:40 PM PDT Jason Ekstrand wrote: On Fri, May 5, 2017 at 12:38 AM, Alejandro Piñeiro wrote: > On 05/05/17 04:11, Jason Ekstrand wrote: > > We have to pass inputs_read through from prog_data because we may add an > >

Re: [Mesa-dev] [PATCH 6/9] i965/vec4: Use NIR remapping for VS attributes

2017-05-05 Thread Alejandro Piñeiro
On 05/05/17 21:31, Jason Ekstrand wrote: > On Fri, May 5, 2017 at 12:38 AM, Alejandro Piñeiro > mailto:apinhe...@igalia.com>> wrote: > > On 05/05/17 04:11, Jason Ekstrand wrote: > > We have to pass inputs_read through from prog_data because we > may add an > > edge flag on old platf

Re: [Mesa-dev] [PATCH 6/9] i965/vec4: Use NIR remapping for VS attributes

2017-05-05 Thread Kenneth Graunke
On Friday, May 5, 2017 12:31:40 PM PDT Jason Ekstrand wrote: > On Fri, May 5, 2017 at 12:38 AM, Alejandro Piñeiro > wrote: > > > On 05/05/17 04:11, Jason Ekstrand wrote: > > > We have to pass inputs_read through from prog_data because we may add an > > > edge flag on old platforms. > > > > Well,

Re: [Mesa-dev] [PATCH 6/9] i965/vec4: Use NIR remapping for VS attributes

2017-05-05 Thread Jason Ekstrand
On Fri, May 5, 2017 at 12:38 AM, Alejandro Piñeiro wrote: > On 05/05/17 04:11, Jason Ekstrand wrote: > > We have to pass inputs_read through from prog_data because we may add an > > edge flag on old platforms. > > Well, the previous code was using nir->info->inputs_read. So perhaps > this explana

Re: [Mesa-dev] [PATCH 6/9] i965/vec4: Use NIR remapping for VS attributes

2017-05-05 Thread Alejandro Piñeiro
On 05/05/17 04:11, Jason Ekstrand wrote: > We have to pass inputs_read through from prog_data because we may add an > edge flag on old platforms. Well, the previous code was using nir->info->inputs_read. So perhaps this explanation should explicitly point that prog_data->inputs_read and nir->info-

[Mesa-dev] [PATCH 6/9] i965/vec4: Use NIR remapping for VS attributes

2017-05-04 Thread Jason Ekstrand
We have to pass inputs_read through from prog_data because we may add an edge flag on old platforms. --- src/intel/compiler/brw_nir.c | 12 +++ src/intel/compiler/brw_nir.h | 2 +- src/intel/compiler/brw_vec4.cpp| 54 +++--- src/