Re: [Mesa-dev] [PATCH 6/9] dispatch_sanity test: move validate_functions into class

2012-10-25 Thread Jordan Justen
On Thu, Oct 25, 2012 at 11:11 AM, Ian Romanick wrote: > On 10/24/2012 02:20 PM, Jordan Justen wrote: >> >> This will allow validate_functions to access ctx.Version. > > Why is this better than just passing ctx.Version as an extra parameter to > validate_functions? I'm not a fan of passing hidden

Re: [Mesa-dev] [PATCH 6/9] dispatch_sanity test: move validate_functions into class

2012-10-25 Thread Ian Romanick
On 10/24/2012 02:20 PM, Jordan Justen wrote: This will allow validate_functions to access ctx.Version. Why is this better than just passing ctx.Version as an extra parameter to validate_functions? I'm not a fan of passing hidden function parameters using the class. Signed-off-by: Jordan

[Mesa-dev] [PATCH 6/9] dispatch_sanity test: move validate_functions into class

2012-10-24 Thread Jordan Justen
This will allow validate_functions to access ctx.Version. Signed-off-by: Jordan Justen --- src/mesa/main/tests/dispatch_sanity.cpp | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispa