Re: [Mesa-dev] [PATCH 6/6] nir/spirv: handle functions with scalar and vector params

2018-07-15 Thread Jason Ekstrand
On Thu, Jul 12, 2018 at 4:30 AM Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/compiler/spirv/vtn_cfg.c | 25 ++--- > 1 file changed, 18 insertions(+), 7 deletions(-) > > diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c > index ed1ab5d1

Re: [Mesa-dev] [PATCH 6/6] nir/spirv: handle functions with scalar and vector params

2018-07-14 Thread Karol Herbst
On Sun, Jul 15, 2018 at 4:58 AM, Jason Ekstrand wrote: > I'm not really sure what this doing. Mind giving some more explanation? Is > this something that's an issue with Vulkan SPIR-V as well? > I am not entirely sure. I know this came up when I called functions having vectors and scalars as ar

Re: [Mesa-dev] [PATCH 6/6] nir/spirv: handle functions with scalar and vector params

2018-07-14 Thread Jason Ekstrand
I'm not really sure what this doing. Mind giving some more explanation? Is this something that's an issue with Vulkan SPIR-V as well? On Thu, Jul 12, 2018 at 4:30 AM Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/compiler/spirv/vtn_cfg.c | 25 ++--- > 1 file

[Mesa-dev] [PATCH 6/6] nir/spirv: handle functions with scalar and vector params

2018-07-12 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/compiler/spirv/vtn_cfg.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c index ed1ab5d1c2c..2b01ede6f81 100644 --- a/src/compiler/spirv/vtn_cfg.c +++ b/sr