Re: [Mesa-dev] [PATCH 5/9] i965/nir: Emit MUL + ADD for MAD on GEN <= 5

2015-03-18 Thread Jason Ekstrand
On Wed, Mar 18, 2015 at 8:43 PM, Kenneth Graunke wrote: > On Wednesday, March 18, 2015 11:27:19 PM Connor Abbott wrote: >> On Wed, Mar 18, 2015 at 11:24 PM, Kenneth Graunke >> wrote: >> > On Tuesday, March 17, 2015 07:17:19 PM Jason Ekstrand wrote: >> >> --- >> >> src/mesa/drivers/dri/i965/brw_

Re: [Mesa-dev] [PATCH 5/9] i965/nir: Emit MUL + ADD for MAD on GEN <= 5

2015-03-18 Thread Kenneth Graunke
On Wednesday, March 18, 2015 11:27:19 PM Connor Abbott wrote: > On Wed, Mar 18, 2015 at 11:24 PM, Kenneth Graunke > wrote: > > On Tuesday, March 17, 2015 07:17:19 PM Jason Ekstrand wrote: > >> --- > >> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 8 +++- > >> 1 file changed, 7 insertions(+), 1

Re: [Mesa-dev] [PATCH 5/9] i965/nir: Emit MUL + ADD for MAD on GEN <= 5

2015-03-18 Thread Connor Abbott
On Wed, Mar 18, 2015 at 11:24 PM, Kenneth Graunke wrote: > On Tuesday, March 17, 2015 07:17:19 PM Jason Ekstrand wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 8 +++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp >

Re: [Mesa-dev] [PATCH 5/9] i965/nir: Emit MUL + ADD for MAD on GEN <= 5

2015-03-18 Thread Kenneth Graunke
On Tuesday, March 17, 2015 07:17:19 PM Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > index 5da8423..41f

Re: [Mesa-dev] [PATCH 5/9] i965/nir: Emit MUL + ADD for MAD on GEN <= 5

2015-03-17 Thread Jason Ekstrand
On Tue, Mar 17, 2015 at 7:35 PM, Connor Abbott wrote: > Instead of doing this, I think it would be better to add something to > nir_shader_compiler_options and do it in nir_opt_algebraic, similar to > what Eric has already done for other things. I've seen some shaders > where we transform a mul +

Re: [Mesa-dev] [PATCH 5/9] i965/nir: Emit MUL + ADD for MAD on GEN <= 5

2015-03-17 Thread Connor Abbott
Instead of doing this, I think it would be better to add something to nir_shader_compiler_options and do it in nir_opt_algebraic, similar to what Eric has already done for other things. I've seen some shaders where we transform a mul + a series of adds into a series of mad's, which is good on gen6+

[Mesa-dev] [PATCH 5/9] i965/nir: Emit MUL + ADD for MAD on GEN <= 5

2015-03-17 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 5da8423..41f9ae2 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b/src/mesa/d