Re: [Mesa-dev] [PATCH 5/8] glsl: Statically cast parameter exec_node to ir_variable.

2014-01-13 Thread Ian Romanick
On 01/11/2014 02:37 AM, Kenneth Graunke wrote: > Formal function parameters are always ir_variable objects, not an > arbitrary ir_instruction. So there's no need to dynamically cast here. ...especially since we never bother to check that as_variable doesn't return NULL. > Signed-off-by: Kenneth

[Mesa-dev] [PATCH 5/8] glsl: Statically cast parameter exec_node to ir_variable.

2014-01-11 Thread Kenneth Graunke
Formal function parameters are always ir_variable objects, not an arbitrary ir_instruction. So there's no need to dynamically cast here. Signed-off-by: Kenneth Graunke --- src/glsl/builtin_functions.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/builtin_functio