Re: [Mesa-dev] [PATCH 5/7] ac/radeonsi: pass bindless bool to load_sampler_desc()

2018-02-26 Thread Samuel Pitoiset
Patches 3 and 5 are : Reviewed-by: Samuel Pitoiset Not sure about 4 to be honest. On 02/20/2018 04:42 AM, Timothy Arceri wrote: We also fix the base_index for bindless by using the driver location. --- src/amd/common/ac_nir_to_llvm.c | 14 +++--- src/amd/common/ac_shad

Re: [Mesa-dev] [PATCH 5/7] ac/radeonsi: pass bindless bool to load_sampler_desc()

2018-02-20 Thread Marek Olšák
On Wed, Feb 21, 2018 at 2:21 AM, Timothy Arceri wrote: > > > On 21/02/18 12:10, Marek Olšák wrote: >> >> On Wed, Feb 21, 2018 at 12:50 AM, Timothy Arceri >> wrote: >>> >>> On 21/02/18 10:33, Marek Olšák wrote: On Tue, Feb 20, 2018 at 11:51 PM, Timothy Arceri wrote: >

Re: [Mesa-dev] [PATCH 5/7] ac/radeonsi: pass bindless bool to load_sampler_desc()

2018-02-20 Thread Timothy Arceri
On 21/02/18 12:10, Marek Olšák wrote: On Wed, Feb 21, 2018 at 12:50 AM, Timothy Arceri wrote: On 21/02/18 10:33, Marek Olšák wrote: On Tue, Feb 20, 2018 at 11:51 PM, Timothy Arceri wrote: On 21/02/18 09:46, Marek Olšák wrote: On Tue, Feb 20, 2018 at 11:42 PM, Marek Olšák wrote: Fo

Re: [Mesa-dev] [PATCH 5/7] ac/radeonsi: pass bindless bool to load_sampler_desc()

2018-02-20 Thread Marek Olšák
On Wed, Feb 21, 2018 at 12:50 AM, Timothy Arceri wrote: > On 21/02/18 10:33, Marek Olšák wrote: >> >> On Tue, Feb 20, 2018 at 11:51 PM, Timothy Arceri >> wrote: >>> >>> On 21/02/18 09:46, Marek Olšák wrote: On Tue, Feb 20, 2018 at 11:42 PM, Marek Olšák wrote: > > > For

Re: [Mesa-dev] [PATCH 5/7] ac/radeonsi: pass bindless bool to load_sampler_desc()

2018-02-20 Thread Timothy Arceri
On 21/02/18 10:33, Marek Olšák wrote: On Tue, Feb 20, 2018 at 11:51 PM, Timothy Arceri wrote: On 21/02/18 09:46, Marek Olšák wrote: On Tue, Feb 20, 2018 at 11:42 PM, Marek Olšák wrote: For patches 1-5: Reviewed-by: Marek Olšák Actually no. Only patches 1, 3, 5 are reviewed by me. Mar

Re: [Mesa-dev] [PATCH 5/7] ac/radeonsi: pass bindless bool to load_sampler_desc()

2018-02-20 Thread Marek Olšák
On Tue, Feb 20, 2018 at 11:51 PM, Timothy Arceri wrote: > On 21/02/18 09:46, Marek Olšák wrote: >> >> On Tue, Feb 20, 2018 at 11:42 PM, Marek Olšák wrote: >>> >>> For patches 1-5: >>> >>> Reviewed-by: Marek Olšák >> >> >> Actually no. Only patches 1, 3, 5 are reviewed by me. >> >> Marek > > > Do

Re: [Mesa-dev] [PATCH 5/7] ac/radeonsi: pass bindless bool to load_sampler_desc()

2018-02-20 Thread Timothy Arceri
On 21/02/18 09:46, Marek Olšák wrote: On Tue, Feb 20, 2018 at 11:42 PM, Marek Olšák wrote: For patches 1-5: Reviewed-by: Marek Olšák Actually no. Only patches 1, 3, 5 are reviewed by me. Marek Do you have an issue with patch 4? ___ mesa-dev mai

Re: [Mesa-dev] [PATCH 5/7] ac/radeonsi: pass bindless bool to load_sampler_desc()

2018-02-20 Thread Marek Olšák
On Tue, Feb 20, 2018 at 11:42 PM, Marek Olšák wrote: > For patches 1-5: > > Reviewed-by: Marek Olšák Actually no. Only patches 1, 3, 5 are reviewed by me. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mai

Re: [Mesa-dev] [PATCH 5/7] ac/radeonsi: pass bindless bool to load_sampler_desc()

2018-02-20 Thread Marek Olšák
For patches 1-5: Reviewed-by: Marek Olšák Marek On Tue, Feb 20, 2018 at 4:42 AM, Timothy Arceri wrote: > We also fix the base_index for bindless by using the driver > location. > --- > src/amd/common/ac_nir_to_llvm.c | 14 +++--- > src/amd/common/ac_shader_abi.h

[Mesa-dev] [PATCH 5/7] ac/radeonsi: pass bindless bool to load_sampler_desc()

2018-02-19 Thread Timothy Arceri
We also fix the base_index for bindless by using the driver location. --- src/amd/common/ac_nir_to_llvm.c | 14 +++--- src/amd/common/ac_shader_abi.h | 3 ++- src/gallium/drivers/radeonsi/si_shader_nir.c | 2 +- 3 files changed, 14 insertions(+), 5 deletions(-)