Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-21 Thread Andy Furniss
Maarten Lankhorst wrote: Well, I found a video that appears to fail in a similar way to one of your failure modes, they could both be the same but showing in different ways. I've found a small mpeg1 vid that causes mplayer: vl/vl_vlc.h:172: vl_vlc_get_vlclbf: Assertion `tbl->length' failed at

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-19 Thread Maarten Lankhorst
On 12/19/2011 11:46 PM, Andy Furniss wrote: > Maarten Lankhorst wrote: >> Hey Andy, >> >> On 12/19/2011 10:17 PM, Andy Furniss wrote: >>> Andy Furniss wrote: >>> I compiled with -O0 but the backtraces are different - maybe there is some randomness. >>> >>> Remembered to attach them this

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-19 Thread Andy Furniss
Maarten Lankhorst wrote: Hey Andy, On 12/19/2011 10:17 PM, Andy Furniss wrote: Andy Furniss wrote: I compiled with -O0 but the backtraces are different - maybe there is some randomness. Remembered to attach them this time :-) Thanks, but nothing seems to be obviously wrong there. I don't s

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-19 Thread Maarten Lankhorst
Hey Andy, On 12/19/2011 10:17 PM, Andy Furniss wrote: > Andy Furniss wrote: > >> I compiled with -O0 but the backtraces are different - maybe there is >> some randomness. > > Remembered to attach them this time :-) Thanks, but nothing seems to be obviously wrong there. I don't suppose you could f

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-19 Thread Andy Furniss
Andy Furniss wrote: I compiled with -O0 but the backtraces are different - maybe there is some randomness. Remembered to attach them this time :-) mplayer: vl/vl_vlc.h:172: vl_vlc_get_vlclbf: Assertion `tbl->length' failed. Program received signal SIGABRT, Aborted. [Switching to Thread 0xb6c

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-19 Thread Andy Furniss
Maarten Lankhorst wrote: Hey Andy, On 12/19/2011 01:50 PM, Andy Furniss wrote: Maarten Lankhorst wrote: Looks like I made the checking a bit too paranoid, causing it to not always decode last few macroblocks because of fear of reaching end of stream.. Does this work? I removed a few paranoid

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-19 Thread Andy Furniss
Maarten Lankhorst wrote: Looks like I made the checking a bit too paranoid, causing it to not always decode last few macroblocks because of fear of reaching end of stream.. Does this work? I removed a few paranoid asserts, and if performance is still bad, I'll alter the patch to swap between m

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-18 Thread Maarten Lankhorst
Hey Andy, 2011/12/19 Andy Furniss : > Maarten Lankhorst wrote: >> >> Hey Andy, >> >> On 12/07/2011 05:48 PM, Andy Furniss wrote: >>> >>> Maarten Lankhorst wrote: >>> Hm, could you test with some added sanity checks? >>> >>> >>> mplayer: vl/vl_vlc.h:139: vl_vlc_eatbits: Assertion `vlc->valid_b

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-18 Thread Andy Furniss
Maarten Lankhorst wrote: Hey Andy, On 12/07/2011 05:48 PM, Andy Furniss wrote: Maarten Lankhorst wrote: Hm, could you test with some added sanity checks? mplayer: vl/vl_vlc.h:139: vl_vlc_eatbits: Assertion `vlc->valid_bits> num_bits' failed. If that works, maybe remove the vl_vlc_fillbi

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-07 Thread Andy Furniss
Maarten Lankhorst wrote: You might want to check with valgrind to see if it tosses any warning, too. I tried valgrind and it does seem that r600 is leaking - below is from a vanilla mesa with a working test stream and vdpau, xvmc leaks half as much with the same stream. In the patched/crashi

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-07 Thread Andy Furniss
Maarten Lankhorst wrote: Hm, could you test with some added sanity checks? mplayer: vl/vl_vlc.h:139: vl_vlc_eatbits: Assertion `vlc->valid_bits > num_bits' failed. If that works, maybe remove the vl_vlc_fillbits call I added in vl_mpeg12_bs_decode to see if that is what caused it. Unfortu

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-07 Thread Maarten Lankhorst
Hey Andy, On 12/06/2011 10:54 PM, Andy Furniss wrote: > Maarten Lankhorst wrote: >> create_buffer, destroy_buffer and set_buffer are a curiosity of >> vl_mpeg12_decoder >> and shouldn't be part of the api. >> >> set_quant_matrix and set_reference_frames shouldn't be separate calls, but >> part o

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-06 Thread Andy Furniss
Maarten Lankhorst wrote: create_buffer, destroy_buffer and set_buffer are a curiosity of vl_mpeg12_decoder and shouldn't be part of the api. set_quant_matrix and set_reference_frames shouldn't be separate calls, but part of picparm, which is a requirement for h264 to work. set_decode_target an

[Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-01 Thread Maarten Lankhorst
create_buffer, destroy_buffer and set_buffer are a curiosity of vl_mpeg12_decoder and shouldn't be part of the api. set_quant_matrix and set_reference_frames shouldn't be separate calls, but part of picparm, which is a requirement for h264 to work. set_decode_target and set_picture_parameters sh