Re: [Mesa-dev] [PATCH 5/6] nir: Fix holes in nir_instr

2018-11-28 Thread Ian Romanick
On 11/28/2018 02:54 AM, Eero Tamminen wrote: > Hi, > > On 28.11.2018 2.38, Ian Romanick wrote: >> From: Ian Romanick >> >> Found using pahole. > > While Pahole does static analysis for binaries, Valgrind has tool that > can do also _run-time_ analysis of structures and other heap allocations > u

Re: [Mesa-dev] [PATCH 5/6] nir: Fix holes in nir_instr

2018-11-28 Thread Eero Tamminen
Hi, On 28.11.2018 2.38, Ian Romanick wrote: From: Ian Romanick Found using pahole. While Pahole does static analysis for binaries, Valgrind has tool that can do also _run-time_ analysis of structures and other heap allocations utilization: http://valgrind.org/docs/manual/dh-manual.ht

[Mesa-dev] [PATCH 5/6] nir: Fix holes in nir_instr

2018-11-27 Thread Ian Romanick
From: Ian Romanick Found using pahole. Changes in peak memory usage according to Valgrind massif: mean soft fp64 using uint64: 1,343,991,403 => 1,342,759,331 gfxbench5 aztec ruins high 11:63,619,971 =>63,555,571 deus ex mankind divided 148: 62,887,728 =>62,845,304 deus ex man