Re: [Mesa-dev] [PATCH 5/5] radeonsi: add preloading for all samplers

2013-03-22 Thread Alex Deucher
On Fri, Mar 22, 2013 at 5:54 AM, Christian König wrote: > Am 21.03.2013 17:20, schrieb Alex Deucher: > >> On Thu, Mar 21, 2013 at 12:09 PM, Christian König >> wrote: >>> >>> Am 21.03.2013 15:10, schrieb Alex Deucher: >>> On Thu, Mar 21, 2013 at 7:38 AM, Christian König wrote: > >>>

Re: [Mesa-dev] [PATCH 5/5] radeonsi: add preloading for all samplers

2013-03-22 Thread Michel Dänzer
On Fre, 2013-03-22 at 11:04 +0100, Christian König wrote: > Am 21.03.2013 17:17, schrieb Michel Dänzer: > > On Don, 2013-03-21 at 17:12 +0100, Christian König wrote: > >> Am 21.03.2013 15:06, schrieb Michel Dänzer: > >>> When I tried this earlier, something broke. Unfortunately, I can't seem > >>>

Re: [Mesa-dev] [PATCH 5/5] radeonsi: add preloading for all samplers

2013-03-22 Thread Christian König
Am 21.03.2013 17:17, schrieb Michel Dänzer: On Don, 2013-03-21 at 17:12 +0100, Christian König wrote: Am 21.03.2013 15:06, schrieb Michel Dänzer: When I tried this earlier, something broke. Unfortunately, I can't seem to remember or dig up if it was a piglit test or e.g. one of the sampler demo

Re: [Mesa-dev] [PATCH 5/5] radeonsi: add preloading for all samplers

2013-03-22 Thread Christian König
Am 21.03.2013 17:20, schrieb Alex Deucher: On Thu, Mar 21, 2013 at 12:09 PM, Christian König wrote: Am 21.03.2013 15:10, schrieb Alex Deucher: On Thu, Mar 21, 2013 at 7:38 AM, Christian König wrote: From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/

Re: [Mesa-dev] [PATCH 5/5] radeonsi: add preloading for all samplers

2013-03-21 Thread Alex Deucher
On Thu, Mar 21, 2013 at 12:09 PM, Christian König wrote: > Am 21.03.2013 15:10, schrieb Alex Deucher: > >> On Thu, Mar 21, 2013 at 7:38 AM, Christian König >> wrote: >>> >>> From: Christian König >>> >>> Signed-off-by: Christian König >>> --- >>> src/gallium/drivers/radeonsi/radeonsi_shader.c

Re: [Mesa-dev] [PATCH 5/5] radeonsi: add preloading for all samplers

2013-03-21 Thread Michel Dänzer
On Don, 2013-03-21 at 17:12 +0100, Christian König wrote: > Am 21.03.2013 15:06, schrieb Michel Dänzer: > > When I tried this earlier, something broke. Unfortunately, I can't seem > > to remember or dig up if it was a piglit test or e.g. one of the sampler > > demos in mesa/demos/src/glsl/. Did yo

Re: [Mesa-dev] [PATCH 5/5] radeonsi: add preloading for all samplers

2013-03-21 Thread Christian König
Am 21.03.2013 15:06, schrieb Michel Dänzer: When I tried this earlier, something broke. Unfortunately, I can't seem to remember or dig up if it was a piglit test or e.g. one of the sampler demos in mesa/demos/src/glsl/. Did you test the latter with this change? Similar concern for patch 4, the r

Re: [Mesa-dev] [PATCH 5/5] radeonsi: add preloading for all samplers

2013-03-21 Thread Christian König
Am 21.03.2013 15:10, schrieb Alex Deucher: On Thu, Mar 21, 2013 at 7:38 AM, Christian König wrote: From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 57 +++- 1 file changed, 45 insertions(+), 12 deletions(-) di

Re: [Mesa-dev] [PATCH 5/5] radeonsi: add preloading for all samplers

2013-03-21 Thread Alex Deucher
On Thu, Mar 21, 2013 at 7:38 AM, Christian König wrote: > From: Christian König > > Signed-off-by: Christian König > --- > src/gallium/drivers/radeonsi/radeonsi_shader.c | 57 > +++- > 1 file changed, 45 insertions(+), 12 deletions(-) > > diff --git a/src/gallium/drivers/

Re: [Mesa-dev] [PATCH 5/5] radeonsi: add preloading for all samplers

2013-03-21 Thread Michel Dänzer
When I tried this earlier, something broke. Unfortunately, I can't seem to remember or dig up if it was a piglit test or e.g. one of the sampler demos in mesa/demos/src/glsl/. Did you test the latter with this change? Similar concern for patch 4, the rest of the series looks good to me. -- Ear

[Mesa-dev] [PATCH 5/5] radeonsi: add preloading for all samplers

2013-03-21 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 57 +++- 1 file changed, 45 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeonsi/radeonsi_shader