Re: [Mesa-dev] [PATCH 5/5] meta: Don't use integer handles for shaders or programs.

2016-03-19 Thread Kenneth Graunke
On Wednesday, March 16, 2016 5:36:25 PM PDT Pohjolainen, Topi wrote: > On Wed, Mar 16, 2016 at 12:13:02AM -0700, Kenneth Graunke wrote: [snip] > > @@ -265,22 +270,21 @@ setup_coord_coeff(GLuint prog, GLuint multiplier, GLuint offset, > > * destination rectangle is adjusted for possible msaa and

Re: [Mesa-dev] [PATCH 5/5] meta: Don't use integer handles for shaders or programs.

2016-03-19 Thread Pohjolainen, Topi
On Wed, Mar 16, 2016 at 12:13:02AM -0700, Kenneth Graunke wrote: > Previously, we gave our internal clear/blit shaders actual GL handles > and stored them in the shader/program hash table. We used ordinary > GL API entrypoints to work with them. > > We thought this shouldn't be a problem because

[Mesa-dev] [PATCH 5/5] meta: Don't use integer handles for shaders or programs.

2016-03-16 Thread Kenneth Graunke
Previously, we gave our internal clear/blit shaders actual GL handles and stored them in the shader/program hash table. We used ordinary GL API entrypoints to work with them. We thought this shouldn't be a problem because GL doesn't allow applications to invent their own names for shaders or prog