Re: [Mesa-dev] [PATCH 5/5] i965/chv: Display proper branding

2016-03-09 Thread Jordan Justen
Series Reviewed-by: Jordan Justen (the version on your branch) On 2016-03-07 17:39:28, Ben Widawsky wrote: > "Braswell" is a Cherryview based *thing*. It unfortunately requires extra > information to determine its marketing name. Unlike all previous products, and > hopefully all future ones, the

Re: [Mesa-dev] [PATCH 5/5] i965/chv: Display proper branding

2016-03-09 Thread Matt Turner
On Wed, Mar 9, 2016 at 10:36 AM, Ben Widawsky wrote: > On Mon, Mar 07, 2016 at 10:11:11PM -0800, Matt Turner wrote: >> On Mon, Mar 7, 2016 at 5:39 PM, Ben Widawsky >> wrote: >> > "Braswell" is a Cherryview based *thing*. It unfortunately requires extra >> > information to determine its marketing

Re: [Mesa-dev] [PATCH 5/5] i965/chv: Display proper branding

2016-03-09 Thread Ben Widawsky
On Mon, Mar 07, 2016 at 10:11:11PM -0800, Matt Turner wrote: > On Mon, Mar 7, 2016 at 5:39 PM, Ben Widawsky > wrote: > > "Braswell" is a Cherryview based *thing*. It unfortunately requires extra > > information to determine its marketing name. Unlike all previous products, > > and > > hopefully a

Re: [Mesa-dev] [PATCH 5/5] i965/chv: Display proper branding

2016-03-07 Thread Rob Clark
On Mon, Mar 7, 2016 at 8:39 PM, Ben Widawsky wrote: > "Braswell" is a Cherryview based *thing*. It unfortunately requires extra > information to determine its marketing name. Unlike all previous products, and > hopefully all future ones, there is no unique 1:1 mapping of PCI device ID to > brand s

Re: [Mesa-dev] [PATCH 5/5] i965/chv: Display proper branding

2016-03-07 Thread Matt Turner
On Mon, Mar 7, 2016 at 5:39 PM, Ben Widawsky wrote: > "Braswell" is a Cherryview based *thing*. It unfortunately requires extra > information to determine its marketing name. Unlike all previous products, and > hopefully all future ones, there is no unique 1:1 mapping of PCI device ID to > brand s

[Mesa-dev] [PATCH 5/5] i965/chv: Display proper branding

2016-03-07 Thread Ben Widawsky
"Braswell" is a Cherryview based *thing*. It unfortunately requires extra information to determine its marketing name. Unlike all previous products, and hopefully all future ones, there is no unique 1:1 mapping of PCI device ID to brand string. I put up a fight about adding any complexity to our G