Hi,
On 23 March 2017 at 14:47, Jason Ekstrand wrote:
> On Thu, Mar 23, 2017 at 6:16 AM, Daniel Stone wrote:
>> Returning int64_t is annoying because the relevant interface demands
>> we need uint32_t, so we need to do casts in users. Given that the
>> offset is useless without the handle/fd, and
On Thu, Mar 23, 2017 at 6:16 AM, Daniel Stone wrote:
> Hi,
>
> On 8 March 2017 at 05:31, Ben Widawsky wrote:
> > Unlike stride, there was no previous offset getter, so it can be right
> > on the first try.
> >
> > v2: Return EINVAL when plane is greater than total planes to make it
> > match the
Hi,
On 8 March 2017 at 05:31, Ben Widawsky wrote:
> Unlike stride, there was no previous offset getter, so it can be right
> on the first try.
>
> v2: Return EINVAL when plane is greater than total planes to make it
> match the similar APIs.
> Avoid leak after fromPlanar (Daniel)
> Make sure when
I made a few trivial comments (mostly just asking for plane == 0 assertions
more places). With that, these 5 are
Reviewed-by: Jason Ekstrand
On Wed, Mar 8, 2017 at 3:09 PM, Jason Ekstrand wrote:
> On Tue, Mar 7, 2017 at 9:31 PM, Ben Widawsky wrote:
>
>> Unlike stride, there was no previous o
On Tue, Mar 7, 2017 at 9:31 PM, Ben Widawsky wrote:
> Unlike stride, there was no previous offset getter, so it can be right
> on the first try.
>
> v2: Return EINVAL when plane is greater than total planes to make it
> match the similar APIs.
> Avoid leak after fromPlanar (Daniel)
> Make sure wh
Unlike stride, there was no previous offset getter, so it can be right
on the first try.
v2: Return EINVAL when plane is greater than total planes to make it
match the similar APIs.
Avoid leak after fromPlanar (Daniel)
Make sure when getting offsets we consider dumb images (Daniel)
v3: Use Jason'
