Re: [Mesa-dev] [PATCH 44/57] mesa: Add ARB_direct_state_access checks in XFB functions

2015-05-15 Thread Ilia Mirkin
On Fri, May 15, 2015 at 2:29 PM, Ian Romanick wrote: > On 05/14/2015 12:51 PM, Ilia Mirkin wrote: >> Don't you have to add the checks either way? And should these have just been >> >> if (ctx->API != CORE && (ctx->API != COMPAT || ctx->Version < 20)) { >> ... >> } >> >> And removing compat will

Re: [Mesa-dev] [PATCH 44/57] mesa: Add ARB_direct_state_access checks in XFB functions

2015-05-15 Thread Ian Romanick
On 05/14/2015 12:51 PM, Ilia Mirkin wrote: > Don't you have to add the checks either way? And should these have just been > > if (ctx->API != CORE && (ctx->API != COMPAT || ctx->Version < 20)) { > ... > } > > And removing compat will just reduce these checks to > > if (ctx->API != CORE) > > ?

Re: [Mesa-dev] [PATCH 44/57] mesa: Add ARB_direct_state_access checks in XFB functions

2015-05-14 Thread Ilia Mirkin
Don't you have to add the checks either way? And should these have just been if (ctx->API != CORE && (ctx->API != COMPAT || ctx->Version < 20)) { ... } And removing compat will just reduce these checks to if (ctx->API != CORE) ? Cheers, -ilia On Thu, May 14, 2015 at 2:55 PM, Ian Romanick

Re: [Mesa-dev] [PATCH 44/57] mesa: Add ARB_direct_state_access checks in XFB functions

2015-05-14 Thread Ian Romanick
I am not a fan of adding a million extra extension checks. I understand that we can't enable the extension universally due to the OpenGL 2.0 requirement. Add this to the list of arguments for making this extension exclusive to core profile... which I have been saying since before a single line of

[Mesa-dev] [PATCH 44/57] mesa: Add ARB_direct_state_access checks in XFB functions

2015-05-11 Thread Fredrik Höglund
Signed-off-by: Fredrik Höglund --- src/mesa/main/transformfeedback.c | 42 +++ 1 file changed, 42 insertions(+) diff --git a/src/mesa/main/transformfeedback.c b/src/mesa/main/transformfeedback.c index 103011c..642fa96 100644 --- a/src/mesa/main/transformfeedb