Re: [Mesa-dev] [PATCH 42/44] spirv: Rework barriers

2017-09-05 Thread Jason Ekstrand
On Tue, Sep 5, 2017 at 8:33 AM, Connor Abbott wrote: > As a quick drive-by, yeah, I noticed this too, and it's going to > require fixes to radv to not break things since none of the other NIR > opcodes are hooked up (this will be needed for the NIR path in > radeonsi too, since GLSL-to-NIR alread

Re: [Mesa-dev] [PATCH 42/44] spirv: Rework barriers

2017-09-05 Thread Connor Abbott
As a quick drive-by, yeah, I noticed this too, and it's going to require fixes to radv to not break things since none of the other NIR opcodes are hooked up (this will be needed for the NIR path in radeonsi too, since GLSL-to-NIR already uses those opcodes). On Tue, Sep 5, 2017 at 11:13 AM, Jason

[Mesa-dev] [PATCH 42/44] spirv: Rework barriers

2017-09-05 Thread Jason Ekstrand
Our previous handling of barriers always used the big hammer and didn't correctly emit memory barriers when specified along with a control barrier. This commit completely reworks the way we emit barriers to make things both more precise and more correct. --- src/compiler/spirv/spirv_to_nir.c | 13