Re: [Mesa-dev] [PATCH 4/8] glsl: Evaluate constant pack/unpack 4x8 expressions

2013-01-25 Thread Matt Turner
On Fri, Jan 25, 2013 at 11:59 AM, Chad Versace wrote: >>> + *x = unpack_1x8((uint8_t) (u & 0xff)); >>> + *y = unpack_1x8((uint8_t) (u >> 8)); >>> + *z = unpack_1x8((uint8_t) (u >> 16)); >>> + *w = unpack_1x8((uint8_t) (u >> 24)); >>> +} >> >> The bitmask (u & 0xff) confused me for a few mo

Re: [Mesa-dev] [PATCH 4/8] glsl: Evaluate constant pack/unpack 4x8 expressions

2013-01-25 Thread Chad Versace
On 01/25/2013 11:38 AM, Chad Versace wrote: > On 01/24/2013 07:47 PM, Matt Turner wrote: >> That is, evaluate constant expressions for the following functions: >> packSnorm4x8, unpackSnorm4x8 >> packUnorm4x8, unpackUnorm4x8 >> --- >> src/glsl/ir_constant_expression.cpp | 162 >> +

Re: [Mesa-dev] [PATCH 4/8] glsl: Evaluate constant pack/unpack 4x8 expressions

2013-01-25 Thread Paul Berry
On 24 January 2013 19:47, Matt Turner wrote: > That is, evaluate constant expressions for the following functions: > packSnorm4x8, unpackSnorm4x8 > packUnorm4x8, unpackUnorm4x8 > --- > src/glsl/ir_constant_expression.cpp | 162 > +++ > 1 files changed, 162 in

[Mesa-dev] [PATCH 4/8] glsl: Evaluate constant pack/unpack 4x8 expressions

2013-01-24 Thread Matt Turner
That is, evaluate constant expressions for the following functions: packSnorm4x8, unpackSnorm4x8 packUnorm4x8, unpackUnorm4x8 --- src/glsl/ir_constant_expression.cpp | 162 +++ 1 files changed, 162 insertions(+), 0 deletions(-) diff --git a/src/glsl/ir_constan