Re: [Mesa-dev] [PATCH 4/8] glcpp: Use string_buffer for line continuation removal

2017-09-06 Thread Nicolai Hähnle
On 29.08.2017 21:56, Thomas Helland wrote: Migrate removal of line continuations to string_buffer. Before this it used ralloc_strncat() to append strings, which internally each time calculates strlen() of its argument. Its argument is entire shader, so it multiple time scans the whole shader text

[Mesa-dev] [PATCH 4/8] glcpp: Use string_buffer for line continuation removal

2017-08-29 Thread Thomas Helland
Migrate removal of line continuations to string_buffer. Before this it used ralloc_strncat() to append strings, which internally each time calculates strlen() of its argument. Its argument is entire shader, so it multiple time scans the whole shader text. Signed-off-by: Vladislav Egorov V2: Adap