Re: [Mesa-dev] [PATCH 4/7] mesa: Convert some runtime asserts to static asserts.

2013-09-22 Thread Kenneth Graunke
On 09/22/2013 01:53 PM, Dave Airlie wrote: > On Sun, Sep 22, 2013 at 12:57 AM, Brian Paul wrote: [snip] >> It's worrisome that our STATIC_ASSERT macro is silent at compile time >> when the expression isn't a compile-time constant. The problem with >> our macro now is variable-sized arrays are OK

Re: [Mesa-dev] [PATCH 4/7] mesa: Convert some runtime asserts to static asserts.

2013-09-22 Thread Dave Airlie
On Sun, Sep 22, 2013 at 12:57 AM, Brian Paul wrote: > On Fri, Sep 20, 2013 at 7:52 PM, Eric Anholt wrote: >> Noticed while grepping through the code for something else. >> --- >> src/mesa/program/program.c | 36 ++-- >> 1 file changed, 22 insertions(+), 14 deletio

Re: [Mesa-dev] [PATCH 4/7] mesa: Convert some runtime asserts to static asserts.

2013-09-22 Thread Eric Anholt
Brian Paul writes: > On Fri, Sep 20, 2013 at 7:52 PM, Eric Anholt wrote: >> Noticed while grepping through the code for something else. >> --- >> src/mesa/program/program.c | 36 ++-- >> 1 file changed, 22 insertions(+), 14 deletions(-) >> >> diff --git a/src/mes

Re: [Mesa-dev] [PATCH 4/7] mesa: Convert some runtime asserts to static asserts.

2013-09-21 Thread Brian Paul
On Fri, Sep 20, 2013 at 7:52 PM, Eric Anholt wrote: > Noticed while grepping through the code for something else. > --- > src/mesa/program/program.c | 36 ++-- > 1 file changed, 22 insertions(+), 14 deletions(-) > > diff --git a/src/mesa/program/program.c b/src/mes

[Mesa-dev] [PATCH 4/7] mesa: Convert some runtime asserts to static asserts.

2013-09-20 Thread Eric Anholt
Noticed while grepping through the code for something else. --- src/mesa/program/program.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c index 2529c13..5dd68d9 100644 --- a/src/mesa