Re: [Mesa-dev] [PATCH 4/7] glsl/tests: changes to test_disk_cache_create test

2018-01-31 Thread Emil Velikov
On 31 January 2018 at 13:55, Tapani Pälli wrote: > > > On 31.01.2018 15:51, Tapani Pälli wrote: >> >> >> >> On 31.01.2018 15:41, Emil Velikov wrote: >>> >>> On 31 January 2018 at 07:17, Tapani Pälli wrote: >>> - /* Before doing anything else, ensure that with -* MESA_GLSL_CACHE_DI

Re: [Mesa-dev] [PATCH 4/7] glsl/tests: changes to test_disk_cache_create test

2018-01-31 Thread Tapani Pälli
On 31.01.2018 15:51, Tapani Pälli wrote: On 31.01.2018 15:41, Emil Velikov wrote: On 31 January 2018 at 07:17, Tapani Pälli wrote: -   /* Before doing anything else, ensure that with -    * MESA_GLSL_CACHE_DISABLE set to true, that disk_cache_create returns NULL. -    */ -   setenv("MES

Re: [Mesa-dev] [PATCH 4/7] glsl/tests: changes to test_disk_cache_create test

2018-01-31 Thread Tapani Pälli
On 31.01.2018 15:41, Emil Velikov wrote: On 31 January 2018 at 07:17, Tapani Pälli wrote: - /* Before doing anything else, ensure that with -* MESA_GLSL_CACHE_DISABLE set to true, that disk_cache_create returns NULL. -*/ - setenv("MESA_GLSL_CACHE_DISABLE", "true", 1); - cache =

Re: [Mesa-dev] [PATCH 4/7] glsl/tests: changes to test_disk_cache_create test

2018-01-31 Thread Emil Velikov
On 31 January 2018 at 07:17, Tapani Pälli wrote: > - /* Before doing anything else, ensure that with > -* MESA_GLSL_CACHE_DISABLE set to true, that disk_cache_create returns > NULL. > -*/ > - setenv("MESA_GLSL_CACHE_DISABLE", "true", 1); > - cache = disk_cache_create("test", "make_

[Mesa-dev] [PATCH 4/7] glsl/tests: changes to test_disk_cache_create test

2018-01-30 Thread Tapani Pälli
Next patch will allow disk_cache instance to be created without path set for it, remove some test cases that assume disk_cache creation to fail with invalid path. To test if different paths work, insert put/get cycle before directory check so that path gets properly created. Signed-off-by: Tapani