Re: [Mesa-dev] [PATCH 4/6] vbo: remove unreachable _mesa_error() call

2011-12-02 Thread Brian Paul
On 12/02/2011 01:36 AM, Jose Fonseca wrote: Brian, The series looks good. BTW, this just remind be of one thing I noticed looking at coverity results before is that it is almost impossible to get zero warnings everywhere. For example, gcc complains that a variable may be used unitialized (whe

Re: [Mesa-dev] [PATCH 4/6] vbo: remove unreachable _mesa_error() call

2011-12-02 Thread Jose Fonseca
Brian, The series looks good. BTW, this just remind be of one thing I noticed looking at coverity results before is that it is almost impossible to get zero warnings everywhere. For example, gcc complains that a variable may be used unitialized (when often it cannot), and setting an initial va

[Mesa-dev] [PATCH 4/6] vbo: remove unreachable _mesa_error() call

2011-12-01 Thread Brian Paul
If mode is not GL_POINT/LINE/FILL we'll have already reported the error earlier in the function and returned so we can never get here. --- src/mesa/vbo/vbo_exec_api.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_api.c b/src/mesa/vbo/vbo_exec_api.