Re: [Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

2017-10-12 Thread Pohjolainen, Topi
On Wed, Oct 11, 2017 at 12:25:29PM -0700, Kenneth Graunke wrote: > On Wednesday, October 11, 2017 9:30:27 AM PDT Pohjolainen, Topi wrote: > > On Tue, Oct 10, 2017 at 03:14:17PM -0700, Kenneth Graunke wrote: > > > From: Topi Pohjolainen > > > > I really don't qualify as an author anymore, you two

Re: [Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

2017-10-11 Thread Kenneth Graunke
On Wednesday, October 11, 2017 8:40:52 AM PDT Jason Ekstrand wrote: > On Tue, Oct 10, 2017 at 3:14 PM, Kenneth Graunke > wrote: > > > From: Topi Pohjolainen > > > > v2: > >- Fix return value (s/MESA_FORMAT_NONE/false/) (Anuj) > >- Move _mesa_tex_format_from_format_and_type() just > >

Re: [Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

2017-10-11 Thread Kenneth Graunke
On Wednesday, October 11, 2017 9:30:27 AM PDT Pohjolainen, Topi wrote: > On Tue, Oct 10, 2017 at 03:14:17PM -0700, Kenneth Graunke wrote: > > From: Topi Pohjolainen > > I really don't qualify as an author anymore, you two have done a lot more work > here since the slim early version of mine. I'v

Re: [Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

2017-10-11 Thread Chris Wilson
Quoting Kenneth Graunke (2017-10-10 23:14:17) > +/* Consider all the restrictions and determine the format of the source. */ > +static mesa_format > +blorp_get_client_format(struct brw_context *brw, > +GLenum format, GLenum type, > +const struct gl_pi

Re: [Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

2017-10-11 Thread Chris Wilson
Quoting Kenneth Graunke (2017-10-10 23:14:17) > +bool > +brw_blorp_download_miptree(struct brw_context *brw, > + struct intel_mipmap_tree *src_mt, > + mesa_format src_format, uint32_t src_swizzle, > + uint32_t level, uint

Re: [Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

2017-10-11 Thread Pohjolainen, Topi
On Tue, Oct 10, 2017 at 03:14:17PM -0700, Kenneth Graunke wrote: > From: Topi Pohjolainen I really don't qualify as an author anymore, you two have done a lot more work here since the slim early version of mine. > > v2: >- Fix return value (s/MESA_FORMAT_NONE/false/) (Anuj) >- Move _mes

Re: [Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

2017-10-11 Thread Jason Ekstrand
On Tue, Oct 10, 2017 at 3:14 PM, Kenneth Graunke wrote: > From: Topi Pohjolainen > > v2: >- Fix return value (s/MESA_FORMAT_NONE/false/) (Anuj) >- Move _mesa_tex_format_from_format_and_type() just > in the end avoiding additional if-block (Anuj) >- Explain better the array align

[Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

2017-10-10 Thread Kenneth Graunke
From: Topi Pohjolainen v2: - Fix return value (s/MESA_FORMAT_NONE/false/) (Anuj) - Move _mesa_tex_format_from_format_and_type() just in the end avoiding additional if-block (Anuj) - Explain better the array alignment restriction (Anuj) - Do not bail out in case of gl_pixelstore_a