Re: [Mesa-dev] [PATCH 4/6] glsl: add support for complie-time constant expressions

2015-11-06 Thread Timothy Arceri
On Fri, 2015-11-06 at 14:17 +, Emil Velikov wrote: > Hi Tim, Hi Emil, Thanks for taking a look over these. > > In my (limited) experience going through the glsl code, I've noticed > that in a few cases we tend to do the same "flags.q.foo && > validate_foo()" in a number of occasions. In some

Re: [Mesa-dev] [PATCH 4/6] glsl: add support for complie-time constant expressions

2015-11-06 Thread Emil Velikov
Hi Tim, In my (limited) experience going through the glsl code, I've noticed that in a few cases we tend to do the same "flags.q.foo && validate_foo()" in a number of occasions. In some cases we silently ignore errors, while on others we omit checking the return value of validate_foo() all togethe

[Mesa-dev] [PATCH 4/6] glsl: add support for complie-time constant expressions

2015-11-05 Thread Timothy Arceri
From: Timothy Arceri In this patch we introduce a new ast type for holding the new compile-time constant expressions. The main reason for this is that we can no longer do merging of layout qualifiers before they have been converted into GLSL IR. The remainder of the patch replaces all the old in