Neil,
Thanks for reviewing. Pushed.
--Jason
On Mon, Aug 11, 2014 at 10:59 AM, Neil Roberts wrote:
> Jason Ekstrand writes:
>
> > + /* If we are on the same miptree, same level, and same slice, then
> > +* intel_miptree_map won't let us map it twice. We have to do
> things a
> > +*
Jason Ekstrand writes:
> + /* If we are on the same miptree, same level, and same slice, then
> +* intel_miptree_map won't let us map it twice. We have to do things a
> +* big differently. In particular, we do a single map large
There's a small typo here.
Otherwise looks great to me
This, together with the meta path, provides a complete implemetation of
ARB_copy_image.
v2: Add a fallback memcpy path for when the texture is too big for the
blitter
v3: Properly support copying between two places on the same texture in the
memcpy fallback
v4: Properly handle blit between
On Fri, Aug 8, 2014 at 4:05 AM, Neil Roberts wrote:
> Jason Ekstrand writes:
>
> > + if (src_mt == dst_mt && src_level == dst_level && src_z == dst_z) {
> > + /* If we are on the same miptree, same level, and same slice, then
> > + * intel_miptree_map won't let us map it twice. We
Jason Ekstrand writes:
> + if (src_mt == dst_mt && src_level == dst_level && src_z == dst_z) {
> + /* If we are on the same miptree, same level, and same slice, then
> + * intel_miptree_map won't let us map it twice. We have to do a
> + * single map in read-write mode.
> +
This, together with the meta path, provides a almost-complete implemetation
of ARB_copy_image. The only case that won't work is if one of the textures
is compressed and has a pitch greater than INT16_MAX. I think that's good
enough to justify turning on the extension.
v2: Add a fallback memcpy p
