Re: [Mesa-dev] [PATCH 4/5] draw/so: account for holes in the stream output

2013-04-25 Thread Zack Rusin
> You can already express holes with the current interface by setting > dst_offset of two outputs such that there is a hole between them (e.g. > dst_offset0 = 0, dst_offset1 = 8). I don't think inserting a dummy > output for the hole is needed. > > Also, the commit summary doesn't say that the gal

Re: [Mesa-dev] [PATCH 4/5] draw/so: account for holes in the stream output

2013-04-25 Thread Marek Olšák
You can already express holes with the current interface by setting dst_offset of two outputs such that there is a hole between them (e.g. dst_offset0 = 0, dst_offset1 = 8). I don't think inserting a dummy output for the hole is needed. Also, the commit summary doesn't say that the gallium interfa

[Mesa-dev] [PATCH 4/5] draw/so: account for holes in the stream output

2013-04-25 Thread Zack Rusin
The spec says that the stream output can have holes if the register index is the maximum possible value, in which case writes to the buffer should be skipped but everything else should be processed as usual. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_pt_so_emit.c | 15 ++